forked from admin/brencher
## Summary Optimizes `.github/workflows/python-package.yml` so the build job runs in ~3-4 minutes instead of ~13 minutes (which is what the recent run on PR #5 took — see https://gitea.rudolf.keenetic.link/admin/brencher/actions/runs/14, started 23:52, completed 00:05, **13m 19s wall-clock**). ## Why it was slow The current matrix has **3 Python versions × 5 checkers = 15 separate CI jobs**, each one: 1. Checking out the repo (~10s) 2. Setting up Python via `actions/setup-python@v3` with **no cache enabled** (~15-30s) 3. Running `pip install -r requirements.txt -r requirements-dev.txt` **from scratch every single time** (~30-90s per job × 15 jobs = 7-22 minutes wasted) The two debug entries (`python -c 'import sys; print(...)'` and `pip list`) were not real checks — they were noise from the upstream github `build-and-test-python` template, left in place but never reviewed. ## What's in this PR - `.github/workflows/python-package.yml` — single file, +41/-56 1. **`cache: 'pip'` enabled** with `cache-dependency-path: requirements.txt, requirements-dev.txt` — first run downloads and caches, subsequent runs hit the cache. Drops pip install from ~60s to ~5-15s when requirements don't change. 2. **Two debug-only matrix entries removed** (`python -c ...` and `pip list`) — they were not real checks. 3. **Matrix restructured**: one Python-version axis only, no checker axis. Each Python job runs `install + flake8 + mypy` sequentially. **15 jobs → 3 jobs** (~5x fewer fresh venvs to set up). 4. **`concurrency: cancel-in-progress: true`** added — a new push to the same PR auto-cancels the previous in-flight run, saving runner minutes when iterating on a fix. 5. Bumped `actions/setup-python` from `v3` to `v5` (required for `cache: 'pip'`). ## Verification - YAML parses via PyYAML — ok - `jobs` dict contains `['build']` only - `build.strategy.matrix.python-version` = `['3.12.3', '3.13', '3.14']` - **total CI jobs: 3** (was 15) - `setup-python@v5` with `cache: 'pip'` + `cache-dependency-path` pointing at `requirements.txt` and `requirements-dev.txt` - `concurrency` block correctly scoped to `ci-${{ github.workflow }}-${{ github.ref }}` ## Expected timing | Scenario | Before | After | |---|---|---| | First run (cold cache) | ~13m 19s | ~5-7m | | Subsequent runs (warm cache, no req changes) | ~13m 19s | ~3-4m | | Re-run after `requirements.txt` change | ~13m 19s | ~4-5m | ## What was NOT verified - Actual Gitea Actions runner behaviour with `cache: 'pip'` — the Gitea Actions runner is GitHub Actions-compatible, and `actions/setup-python@v5` with `cache: 'pip'` is a well-known idiom there, but the local Gitea runner config may or may not honour it. If it doesn't, the 15→3 fan-out reduction alone is still a ~5x speedup. ## Note on PR #14 PR #14 ("re-enable the tests job") is still open. If/when it merges, this PR will need a follow-up to re-add the `tests:` job with the same `cache: 'pip'` setup applied — otherwise the playwright install will dominate again. ## Commit history ``` *db3807e(HEAD -> feat/optimize-ci-build-time, origin/feat/optimize-ci-build-time) ci: speed up python-package.yml from ~13min to ~3-4min *70f4a41ci: comment out the tests job in python-package.yml (#13) (upstream/main tip) ``` --------- Co-authored-by: admin <rudolfss13@gmail.com> Co-authored-by: hermes <hermes@rudolf.keenetic.link> Reviewed-on: http://192.168.1.96/admin/brencher/pulls/15 Co-authored-by: hermes <rudolfss13+hermes@gmail.com>
46 lines
1.2 KiB
YAML
46 lines
1.2 KiB
YAML
name: Python package
|
|
|
|
on:
|
|
workflow_dispatch:
|
|
push:
|
|
branches: [ "main" ]
|
|
pull_request:
|
|
branches: [ "main" ]
|
|
|
|
concurrency:
|
|
group: ci-${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
python-version: ["3.12.3", "3.13", "3.14"]
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- name: Set up Python ${{ matrix.python-version }}
|
|
uses: actions/setup-python@v5
|
|
with:
|
|
python-version: ${{ matrix.python-version }}
|
|
cache: 'pip'
|
|
cache-dependency-path: |
|
|
requirements.txt
|
|
requirements-dev.txt
|
|
|
|
- name: Install dependencies
|
|
run: |
|
|
python -m pip install --upgrade pip
|
|
pip install -r requirements.txt
|
|
pip install -r requirements-dev.txt
|
|
|
|
- name: Lint (flake8)
|
|
run: |
|
|
flake8 . --count --select=E9,F63,F7,F82 --ignore=F824 --show-source --statistics
|
|
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
|
|
|
|
- name: Type-check (mypy)
|
|
run: mypy --no-incremental --config-file mypy.ini backend tests |