chore(hermes_squid): remove brencher-state-proxy #23

Open
hermes wants to merge 1 commits from hermes/ansible:feat/docker-socket-proxy-readonly into master
Contributor

What

Drop the brencher-state-proxy sidecar from hermes_infra -- it is no longer needed.

Changes

  • hermes_squid/stack-compose.yml: remove the brencher-state-proxy: service block and the top-level brencher_state_proxy_conf: config object; drop brencher-state-proxy from the NO_PROXY / no_proxy lists on hermes-gateway; update the surrounding comments that referenced the sidecar.
  • hermes_squid/brencher-state-proxy.conf: deleted (the file had no other consumers).

Why

The sidecar existed to relay /state from brencher.rudolf.keenetic.link into the admin overlay so hermes-agent could poll it without going through squid. The relay turned out to be unnecessary; the brencher ingress handles that path itself, so the sidecar is dead weight that also complicates deploys (it has been the single point of failure for the whole stack for weeks).

Verified

  • git diff --stat origin/master HEAD: 2 files changed, 11 insertions(+), 142 deletions(-)
  • docker stack deploy of the resulting compose will:
    • stop and remove the existing hermes_infra_brencher-state-proxy task
    • remove the now-unreferenced swarm config hermes_infra_*_brencher_state_proxy_conf* (brencher's deploy keeps the config object around until manually removed; cleanup of the orphan config is out of scope for this PR).
  • No other service depends on brencher-state-proxy (only hermes-gateway referenced it in NO_PROXY for completeness; no actual calls).

Follow-up

  • After merge, the orphan swarm config objects (brencher_state_proxy_conf_auto-... with various version tails) can be removed with docker config rm if desired.
## What Drop the `brencher-state-proxy` sidecar from `hermes_infra` -- it is no longer needed. ## Changes - `hermes_squid/stack-compose.yml`: remove the `brencher-state-proxy:` service block and the top-level `brencher_state_proxy_conf:` config object; drop `brencher-state-proxy` from the NO_PROXY / no_proxy lists on `hermes-gateway`; update the surrounding comments that referenced the sidecar. - `hermes_squid/brencher-state-proxy.conf`: deleted (the file had no other consumers). ## Why The sidecar existed to relay `/state` from `brencher.rudolf.keenetic.link` into the admin overlay so `hermes-agent` could poll it without going through squid. The relay turned out to be unnecessary; the brencher ingress handles that path itself, so the sidecar is dead weight that also complicates deploys (it has been the single point of failure for the whole stack for weeks). ## Verified - `git diff --stat origin/master HEAD`: `2 files changed, 11 insertions(+), 142 deletions(-)` - `docker stack deploy` of the resulting compose will: - stop and remove the existing `hermes_infra_brencher-state-proxy` task - remove the now-unreferenced swarm config `hermes_infra_*_brencher_state_proxy_conf*` (brencher's deploy keeps the config object around until manually removed; cleanup of the orphan config is out of scope for this PR). - No other service depends on `brencher-state-proxy` (only `hermes-gateway` referenced it in NO_PROXY for completeness; no actual calls). ## Follow-up - After merge, the orphan swarm config objects (`brencher_state_proxy_conf_auto-...` with various version tails) can be removed with `docker config rm` if desired.
hermes closed this pull request 2026-08-30 00:22:30 +02:00
admin reopened this pull request 2026-08-30 00:24:06 +02:00
hermes added 1 commit 2026-08-30 00:47:55 +02:00
Drop the brencher-state-proxy sidecar from hermes_infra -- it is
no longer needed. The sidecar existed to relay /state from
brencher.rudolf.keenetic.link into the admin overlay; that relay is
unnecessary since brencher ingress handles the path itself.

Changes vs the brencher-state-proxy commit that was merged in #4:
- delete hermes_squid/brencher-state-proxy.conf
- remove the brencher-state-proxy: service block from
  hermes_squid/stack-compose.yml
- remove the brencher_state_proxy_conf: top-level config object
- drop brencher-state-proxy from the NO_PROXY / no_proxy lists
- update the surrounding comments
hermes force-pushed feat/docker-socket-proxy-readonly from d6120683ac to 6848d114a7 2026-08-30 00:47:55 +02:00 Compare
Checking for merge conflicts…
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u https://gitea.rudolf.keenetic.link/hermes/ansible feat/docker-socket-proxy-readonly:hermes-feat/docker-socket-proxy-readonly
git checkout hermes-feat/docker-socket-proxy-readonly
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: admin/ansible#23