This commit is contained in:
2026-05-09 23:55:34 +02:00
parent 8c13360c0c
commit c00ebb7d6d
3 changed files with 18 additions and 10 deletions
+4
View File
@@ -71,6 +71,10 @@ class DockerImageBuild(AbstractStep[DockerImageBuildResult]):
if len(existing_image) > 0 and not self.nocache:
logger.info(f"Image {full_image} already exists locally with ID: {existing_image}")
build_logs: List[str] = []
elif self.env.dry:
logger.info(f"DRY RUN: Would build image {full_image}")
raise BaseException(f"Dry run - skipping actual build for {full_image}")
else:
# Build the image
build_logs = []
+1 -1
View File
@@ -38,7 +38,7 @@ def assert_equal(a: T, b:T, message: str) -> None:
if a != b:
raise AssertionError(f"{message}: {a} != {b}")
def _check_state(url: str, predicate: Callable[[Any], None]) -> None:
def check_state(url: str, predicate: Callable[[Any], None]) -> None:
response = requests.get(f"{url}/state", timeout=5)
assert response.status_code == 200, f"Expected status code 200, got {response.status_code}"
state_data = response.json()
+13 -9
View File
@@ -6,7 +6,7 @@ import docker
import pytest
import requests
from app import App
from .conftest import EventuallyFn, _check_state, assert_equal
from .conftest import EventuallyFn, assert_equal, check_state
from .playwright_helper import brencher_page
from configs import brencher_local1
@@ -48,11 +48,9 @@ class TestDryRunPlaywright:
# DockerContainerDeploy should return status="dry-run"
with brencher_page(APP_URL) as page:
eventually(
lambda: _check_state(APP_URL, lambda s: assert_equal(
next(p for p in s[ENV_ID]["pipeline"] if p["name"] == "DockerContainerDeploy")["status"].get('status'),
"dry-run",
"Pipeline step status is not 'dry-run'"
)),
lambda: check_state(APP_URL, lambda s: assert_equal(next(
p for p in s[ENV_ID]["pipeline"] if p["name"] == "SharedStateHolderInMemory"
)["status"]['dry'], True, "Pipeline step status is not 'running'")),
)
# page.verify_pipeline_step_status("DockerContainerDeploy", "dry-run")
@@ -71,9 +69,15 @@ class TestDryRunPlaywright:
# Wait for pipeline to re-run and actually deploy the container
eventually(
lambda: _check_state(APP_URL, lambda s: assert_equal(next(
p for p in s[ENV_ID]["pipeline"] if p["name"] == "DockerContainerDeploy"
)["status"].get('status'), "running", "Pipeline step status is not 'running'")),
lambda: check_state(APP_URL, lambda s: assert_equal(next(
p for p in s[ENV_ID]["pipeline"] if p["name"] =="SharedStateHolderInMemory"
)["status"]['dry'], False, "Pipeline step status is not 'running'")),
)
# Wait for pipeline to re-run and actually deploy the container
eventually(
lambda: check_state(APP_URL, lambda s: assert_equal({p["name"] for p in s[ENV_ID]["pipeline"] if bool(p['is_running'])}, set(), "Pipeline still running")),
timeout=60,
interval=1.0,
)
# page.verify_pipeline_step_status("DockerContainerDeploy", "running")
logger.info("Container deployed and running after dry run disabled")